Great job making this timer, it should help people know when Christmas is, but my friend Skeeter and I noticed an issue.
The way your timer works, it rounds down if over halfway through the millisecond, second, hour, or day, then rounds down otherwise. For example, I'm writing this around 12:15pm my time on Dec 6, and the "days" reads 19. 19 + 6 = 25, so that's good. However when I was looking 30 minutes ago, the days read 20 instead. I messed around with time zones on my computer to confirm this was a consistent issue (since this timer is based on the user's system clock), and yes, any time before noon rounds up on days, any time before noon rounds down.
The issue with this is that the days will stay at 1 away until noon on Christmas, which obviously could lead to an issue of people not celebrating an entire half of Christmas day. I know you want to be helpful, and not inadvertently halve the celebration of this wonderful holiday so I wanted to let you know before it was too late.
The fix to this would be to make sure the timer always rounds down no matter what (ie. 19.99 days should round down to 19 days on your timer display). That way the day changes at midnight, and all timers will hit zero right at midnight on Christmas day instead of at noon. I don't know what coding language you used for this, but there is most likely a "floor" function for rounding, that should allow you to always round down.
I hope this makes sense and allows a more accurate celebration of Christmas.
← Return to game
Comments
Log in with itch.io to leave a comment.
Hey MilkManIsSad,
Great job making this timer, it should help people know when Christmas is, but my friend Skeeter and I noticed an issue.
The way your timer works, it rounds down if over halfway through the millisecond, second, hour, or day, then rounds down otherwise. For example, I'm writing this around 12:15pm my time on Dec 6, and the "days" reads 19. 19 + 6 = 25, so that's good. However when I was looking 30 minutes ago, the days read 20 instead. I messed around with time zones on my computer to confirm this was a consistent issue (since this timer is based on the user's system clock), and yes, any time before noon rounds up on days, any time before noon rounds down.
The issue with this is that the days will stay at 1 away until noon on Christmas, which obviously could lead to an issue of people not celebrating an entire half of Christmas day. I know you want to be helpful, and not inadvertently halve the celebration of this wonderful holiday so I wanted to let you know before it was too late.
The fix to this would be to make sure the timer always rounds down no matter what (ie. 19.99 days should round down to 19 days on your timer display). That way the day changes at midnight, and all timers will hit zero right at midnight on Christmas day instead of at noon. I don't know what coding language you used for this, but there is most likely a "floor" function for rounding, that should allow you to always round down.
I hope this makes sense and allows a more accurate celebration of Christmas.
Happy Holidays,
Sam
Also my friend Skeeter felt inspired to add a little flair to your background. Feel free to use it if you wish!
Thank you, I'm working on it right now! Also, thanks for the background!
Does it work now?
Looks like it still rounds at Noon. Seems like hour might be fixed though? Days are still wrong though.
Dude I have no idea what's going on. I'mma look into it lol
Decimals! Nice solution
I just took out the rounding code cause I couldn't figure it out lol.